We're updating the issue view to help you get more done. 

DSA allows diagnosis date before birth date

Description

Problem

Tidepool Web's DSA creation page allows users to specify a diagnosis date that precedes the date of birth. Confirmed on prd and stg.

Should be noted that after the DSA is created trying to change the diagnosis date to before the birth date will result in a an error message that says "Hmm, diagnosis date usually comes after birthday", which is expected behavior. Implementing the same message during initial DSA creation would be a good fix.

Done Criteria

  • When setting up an initial DSA, specifying a diagnosis date that precedes the birthday is not allowed and results in displaying a message underneath the diagnosis date in red font “Hmm, diagnosis date usually comes after birthday.”

Design Specifications:

None

Accessibility Specifications

None

Test Strategy

Create a new account, try to make the diagnosis date earlier than birthdate. This action should not be allowed with an error message of “Hmm, diagnosis date usually comes after birthday.”

Environment

Activity

Show:
Janet Diehl
June 28, 2019, 4:10 AM

Ginny Yadav May 30 at 8:29 AM

Adding some more info/screenshots as I've recently rediscovered this bug

Reply - Delete

Clint Beacock moved this card from Assigned, Risk Level: 4-11 to Assigned, Risk Level: 0

Mar 29 at 6:32 AM

Clint Beacock Mar 29 at 6:32 AM

@bcooney1 I've reassessed the risk analysis on this one, and have set it to 0. It was previously set to 4, but it was incorrectly assuming probability meant probability of the bug occurring rather than probability of harm.

Reply - Delete

Clint Beacock updated the value for the Scope custom field on this card

Mar 29 at 6:28 AM

Clint Beacock updated the value for the Risk Level custom field on this card

Mar 29 at 6:28 AM

BCooney moved this card from Needs Repro Steps & Risk Assessment to Assigned, Risk Level: 4-11

Mar 5 at 4:33 PM

Nick Riggall Dec 13, 2017 at 6:32 PM

Just changing the title.

Reply

Eric Luhrs attached Screen Shot 2017-12-13 at 9.03.05 AM.png to this card Dec 13, 2017 at 2:35 PM

JP Reilly
July 1, 2019, 5:47 PM
Ginny Yadav
July 12, 2019, 11:46 PM

specified done criteria, cleaned up card from Trello formatting, added test verification doc, updated test strategy.

Ginny Yadav
July 12, 2019, 11:51 PM

✔ QA Pass
Success. When setting up an initial DSA, specifying a diagnosis date that precedes the birthday is not allowed and results in displaying a message underneath the diagnosis date in red font “Hmm, diagnosis date usually comes after birthday.”

Tapani Otala
July 13, 2019, 12:14 AM

LGTM!

Done

Priority

Assignee

Clint Beacock

QA Assignee

Ginny Yadav

Reporter

Janet Diehl

Requested By (External)

None

Fix versions

T-Shirt Size

S: 2-3 days

Risk Level

0

User Experience Assessment Level

1

UEA: Issue Volume

None

UEA: Category

None

Components

None

Design Review Required?

No

Design Approved By:

None

QA done during validation of another ticket?

None

Accessibility Review Required?

None

Accessibility Review Approved By

None

Approved for Production By:

Tapani

Marketing Comms

No

Support Follow Up

No

KB Update

No

Pull Request Needed

None

Resolved Build #

None

Dev Documentation

Yes

KissMetrics Events Implemented?

N/A

Story Points

3
Configure